Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 14466 invoked by uid 500); 18 Nov 2000 15:32:14 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 14451 invoked from network); 18 Nov 2000 15:32:13 -0000 Errors-To: From: "William A. Rowe, Jr." To: Subject: RE: cvs commit: apache-2.0/src/modules/standard mod_cgi.c Date: Sat, 18 Nov 2000 09:32:09 -0600 Message-ID: <000001c05174$b8176110$92c0b0d0@roweclan.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6600 Importance: Normal X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N You are right. I proposed apr_delta_time_t or apr_short_time_t a very, very long time ago, nobody bit. The simple fact is something -is- wrong, we work with 32 bit time, and timeouts are 16 bit. c'est la vie If you prefer, I'll create an APR_SHORT_TIME macro to convert these. Bill > -----Original Message----- > From: rbb@covalent.net [mailto:rbb@covalent.net] > Sent: Saturday, November 18, 2000 9:28 AM > To: new-httpd@apache.org > Cc: apache-2.0-cvs@apache.org > Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_cgi.c > > > On 18 Nov 2000 wrowe@locus.apache.org wrote: > > > wrowe 00/11/18 07:12:48 > > > > Modified: src/modules/standard mod_cgi.c > > Log: > > Cleanup more compiler warnings. > > Woah. The general rule in Apache code is if we are casting, then > something is wrong. Why are all of these casts suddenly > needed? Plus, > these aren't int's that you are casting. They should be apr_time_t or > apr_interval_time_t. I can't remember which they are right now. > > > apr_set_pipe_timeout(*script_in, > > - r->server->timeout * > APR_USEC_PER_SEC); > > + > (int)(r->server->timeout * APR_USEC_PER_SEC)); > > > > *script_out = procnew->in; > > if (!*script_out) > > return APR_EBADF; > > apr_set_pipe_timeout(*script_out, > > - r->server->timeout * > APR_USEC_PER_SEC); > > + > (int)(r->server->timeout * APR_USEC_PER_SEC)); > > > > *script_err = procnew->err; > > if (!*script_err) > > return APR_EBADF; > > apr_set_pipe_timeout(*script_err, > > - r->server->timeout * > APR_USEC_PER_SEC); > > + > (int)(r->server->timeout * APR_USEC_PER_SEC)); > > } > > } > > return (rc); > > > > > > > > > > > > > ______________________________________________________________ > _________________ > Ryan Bloom rbb@apache.org > 406 29th St. > San Francisco, CA 94131 > -------------------------------------------------------------- > ----------------- > >