httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix sockets.c
Date Sun, 19 Nov 2000 01:49:57 GMT
Greg Stein <gstein@lyra.org> writes:

> On Sat, Nov 18, 2000 at 03:32:16PM -0000, dreid@locus.apache.org wrote:
> > dreid       00/11/18 07:32:16
> > 
> >   Modified:    src/lib/apr/network_io/unix sockets.c
> >   Log:
> >   Hide an instance of AF_INET6 if we don't have IPv6 and start adding
> >   code to allow BeOS to use this file.
> >...
> >        }
> >   @@ -246,6 +250,7 @@
> >                sock->local_port_unknown = 1;
> >            }
> >            /* XXX IPv6 to be handled better later... */
> >   +#if APR_HAVE_IPV6
> >            if (sock->local_addr->sa.sin.sin_family == AF_INET6 ||
> >                sock->local_addr->sa.sin.sin_addr.s_addr == 0) {
> >                /* not bound to specific local interface; connect() had to assign
> 
> Um. Does the #if accidentally prevent the second part of that condition from
> executing?
> 
> For example, what if the family was IPv4 and s_addr == 0. ??

yessir; good catch...  I'll try to remedy that problem tonight or
early tomorrow morning

Thanks as always,
-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message