httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sascha Schumann <sas...@schumann.cx>
Subject Re: cvs commit: apache-2.0/src/main http_core.c
Date Thu, 02 Nov 2000 21:22:20 GMT
On Thu, 2 Nov 2000, Greg Stein wrote:

> Woah! Wait a sec.
>
> Why is this done? discard_request_body() will already do this. And you
> really need to discard the body for *any* method, not just POST methods.
>
> If I send a PROPFIND method, and it ends up at the default handler, then the
> PROPFIND body better get thrown out.

    Right, I committed on the wrong machine in a broken tree. :(
    I'll fix that ASAP.

> I don't understand two things with this patch:
>
> 1) why there is a new function to duplicate what discard does
> 2) why it gets used on a POST instead of the standard discard

    The difference basically boils down to this line:

> >   +    if ((rv = ap_setup_client_block(r, REQUEST_CHUNKED_DECHUNK)))

    ap_discard_request_body() uses REQUEST_CHUNKED_PASS which is
    not what we need, if I understand the comments correctly.

    - Sascha



Mime
View raw message