httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject RE: cvs commit: apache-2.0/src/modules/standard mod_cgi.c
Date Sat, 18 Nov 2000 15:46:38 GMT

Would it work to just convert the timeout in the server_rec to the
apr_interval_time_t?

Ryan

On Sat, 18 Nov 2000, William A. Rowe, Jr. wrote:

> You are right.
> 
> I proposed apr_delta_time_t or apr_short_time_t a very, very long
> time ago, nobody bit.  The simple fact is something -is- wrong, we
> work with 32 bit time, and timeouts are 16 bit.  c'est la vie
> 
> If you prefer, I'll create an APR_SHORT_TIME macro to convert these.
> 
> Bill
> 
> 
> > -----Original Message-----
> > From: rbb@covalent.net [mailto:rbb@covalent.net]
> > Sent: Saturday, November 18, 2000 9:28 AM
> > To: new-httpd@apache.org
> > Cc: apache-2.0-cvs@apache.org
> > Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_cgi.c
> > 
> > 
> > On 18 Nov 2000 wrowe@locus.apache.org wrote:
> > 
> > > wrowe       00/11/18 07:12:48
> > > 
> > >   Modified:    src/modules/standard mod_cgi.c
> > >   Log:
> > >     Cleanup more compiler warnings.
> > 
> > Woah.  The general rule in Apache code is if we are casting, then
> > something is wrong.  Why are all of these casts suddenly 
> > needed?  Plus,
> > these aren't int's that you are casting.  They should be apr_time_t or
> > apr_interval_time_t.  I can't remember which they are right now.
> > 
> > >                apr_set_pipe_timeout(*script_in, 
> > >   -                                 r->server->timeout * 
> > APR_USEC_PER_SEC);
> > >   +                                 
> > (int)(r->server->timeout * APR_USEC_PER_SEC));
> > >    
> > >                *script_out = procnew->in;
> > >                if (!*script_out)
> > >                    return APR_EBADF;
> > >                apr_set_pipe_timeout(*script_out, 
> > >   -                                 r->server->timeout * 
> > APR_USEC_PER_SEC);
> > >   +                                 
> > (int)(r->server->timeout * APR_USEC_PER_SEC));
> > >    
> > >                *script_err = procnew->err;
> > >                if (!*script_err)
> > >                    return APR_EBADF;
> > >                apr_set_pipe_timeout(*script_err, 
> > >   -                                 r->server->timeout * 
> > APR_USEC_PER_SEC);
> > >   +                                 
> > (int)(r->server->timeout * APR_USEC_PER_SEC));
> > >            }
> > >        }
> > >        return (rc);
> > >   
> > >   
> > >   
> > > 
> > > 
> > 
> > 
> > ______________________________________________________________
> > _________________
> > Ryan Bloom                        	rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > --------------------------------------------------------------
> > -----------------
> > 
> > 
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message