httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_cgi.c
Date Sat, 18 Nov 2000 15:27:53 GMT
On 18 Nov 2000 wrowe@locus.apache.org wrote:

> wrowe       00/11/18 07:12:48
> 
>   Modified:    src/modules/standard mod_cgi.c
>   Log:
>     Cleanup more compiler warnings.

Woah.  The general rule in Apache code is if we are casting, then
something is wrong.  Why are all of these casts suddenly needed?  Plus,
these aren't int's that you are casting.  They should be apr_time_t or
apr_interval_time_t.  I can't remember which they are right now.

>                apr_set_pipe_timeout(*script_in, 
>   -                                 r->server->timeout * APR_USEC_PER_SEC);
>   +                                 (int)(r->server->timeout * APR_USEC_PER_SEC));
>    
>                *script_out = procnew->in;
>                if (!*script_out)
>                    return APR_EBADF;
>                apr_set_pipe_timeout(*script_out, 
>   -                                 r->server->timeout * APR_USEC_PER_SEC);
>   +                                 (int)(r->server->timeout * APR_USEC_PER_SEC));
>    
>                *script_err = procnew->err;
>                if (!*script_err)
>                    return APR_EBADF;
>                apr_set_pipe_timeout(*script_err, 
>   -                                 r->server->timeout * APR_USEC_PER_SEC);
>   +                                 (int)(r->server->timeout * APR_USEC_PER_SEC));
>            }
>        }
>        return (rc);
>   
>   
>   
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message