httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/lib/apr/misc/unix Makefile.in otherchild.c misc.h
Date Thu, 09 Nov 2000 07:11:08 GMT
On Wed, 8 Nov 2000, Greg Stein wrote:

> On Thu, Nov 09, 2000 at 06:30:13AM -0000, rbb@locus.apache.org wrote:
> >...
> >   --- otherchild.c	2000/10/16 06:04:47	1.16
> >   +++ otherchild.c	2000/11/09 06:30:11	1.17
> >   @@ -55,7 +55,7 @@
> >    #include "apr.h"
> >    #include "misc.h"
> >    #include "threadproc.h"
> >   -#include "../../file_io/unix/fileio.h"
> >   +#include "fileio.h"
> >    #ifdef HAVE_TIME_H
> >    #include <sys/time.h>
> >    #endif
> 
> Should that be unix/fileio.h ?

No.  This is correct.  The reason for the difference is that the
misc/unix/Makefile sets and INCDIR of arch/@OSDIR@.  The reason for this,
is that the fileio.h is used from the appropriate OS.  We need the correct
definition for apr_file_t's based on each platform, so we can't just
include the unix version, because other platforms may use a different
apr_file_t.  The reason this works, is that all platforms that use this
code have a filedes field in the apr_file_t.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message