httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] Quick AIX type fix...
Date Tue, 07 Nov 2000 10:56:59 GMT


I am not going to commit this, because it is going the wrong way.  :-)  I
agree that this does fix a compile warning, but the length parameter to
bucket_read should be apr_size_t.  Those functions cannot return negative
values anymore, so the values shouldn't be signed.  This is the same
change we are making to the APR read/write functions.

Ryan

On Mon, 6 Nov 2000, Victor J. Orlikowski wrote:

> Just a type clean-up...
> 
> Index: src/main/http_protocol.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/main/http_protocol.c,v
> retrieving revision 1.227
> diff -u -d -b -r1.227 http_protocol.c
> --- http_protocol.c     2000/11/06 20:43:19     1.227
> +++ http_protocol.c     2000/11/06 23:54:42
> @@ -930,7 +930,7 @@
>           */
>          ap_bucket *e;
>          const char *str;
> -        apr_size_t length;
> +        apr_ssize_t length;
> 
>          e = AP_BRIGADE_FIRST(ctx->b);
>          while (e->length == 0) {
> 
> Victor
> -- 
> Victor J. Orlikowski
> ======================
> v.j.orlikowski@gte.net
> vjo@raleigh.ibm.com
> vjo@us.ibm.com
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message