httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] byterange handling with filters
Date Thu, 02 Nov 2000 23:43:01 GMT
On Thu, 2 Nov 2000, Greg Stein wrote:

> On Thu, Nov 02, 2000 at 03:26:44PM -0800, rbb@covalent.net wrote:
> > 
> > I am pretty sure that this is incorrect, and that the correct solution is
> > a filter, but this is at least an attempt at getting byte-ranges working
> > with filters.  This is completely untested, so feel free to yell and
> > scream at me.  :-)
> 
> 1) yell and scream: stop submitting code that you believe is broken. let's
>    keep apache working, rather than knowingly breaking it

Did I commit the code?  No.  I submitted it for review because I wanted
people to review it.  If you don't want to review untested code, then hit
delete as soon as you read that I haven't tested it yet. :-)

> 2) comment: what are the ap_rflush() calls doing in there?

If we don't flush the data that we have already sent, then the byte-range
information will end up at the wrong point in the response.  This is why I
am not sure that the code will actually work, and I think this should be a
filter.

> 3) comment: it does appear that it will work fine

Cool.  I'm hoping to be able to test it before I commit tomorrow.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message