httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/aputil apu_private.hw
Date Thu, 30 Nov 2000 18:37:47 GMT
On Thu, Nov 30, 2000 at 09:57:42AM -0800, William A. Rowe, Jr. wrote:
> From: "Greg Stein" <gstein@lyra.org>
> To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
> >
> > Ooh... I may know what this is. I changed a few lines that looked like:
> > 
> >     char const *foo;
> > 
> > to the standard Apache-style: (hell, everybody's style)
> > 
> >     const char *foo;
> > 
> > Do you think that if we put a few of the decls back to the former style,
> > that the warnings will go away?
> 
> Doubt it... I believe the constness tests may be foobared in VC5 (specifically
> VC5... FirstBill - can you compile on VC6 :-?)
> 
> But toss a patch my way and I'll let you know if they do go away.


Try this one. If my guess is right, it will eliminate a few warnings around
line 600.

Index: service.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/modules/mpm/winnt/service.c,v
retrieving revision 1.26
diff -u -r1.26 service.c
--- service.c   2000/11/29 17:33:03     1.26
+++ service.c   2000/11/30 18:32:09
@@ -595,7 +595,7 @@
      */
     if (argc > 1) 
     {
-        const char **cmb_data;
+        char const **cmb_data;
 
         mpm_new_argv->nalloc = mpm_new_argv->nelts + argc - 1;
         cmb_data = apr_palloc(mpm_new_argv->cont,


-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message