httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] ap_r* efficiency improvements
Date Tue, 14 Nov 2000 21:03:58 GMT
On Tue, Nov 14, 2000 at 12:44:52PM -0800, rbb@covalent.net wrote:
> On Tue, 14 Nov 2000, Greg Stein wrote:
> > Eek. No way on this patch. This is just a new implementation of the
> > buffering that we did in BUFF.
> 
> I agree 100% with Greg on this.

*gasp*

:-)

> > I'd rather see the coalesce filter installed at the head of the filter
> > stack. Effectively, if it is AP_FTYPE_CONTENT and is installed "first", then
> > it will coalesce all blocks for delivery to the rest of the filters.
> 
> On this we disagree, but I will accept it, provided that this filter only
> gets installed when ap_r* is called for the first time.

Fine with me, but I believe we would then want a filter type that precedes
CONTENT. (to ensure that a filter added a late date would be inserted before
the other CONTENT filters; call this PREPROCESS [brigade] or something?)

> That will allow
> handlers that want to be smart about their writing to avoid this filter
> all-together.  handlers that are using the buckets and want the coalesce
> filter can insert it themselves as well.

I believe that handlers that operate with buckets will never use the
coalesce filter. They seem to be mutually exclusive.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message