httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/test testsf.c
Date Fri, 03 Nov 2000 23:09:31 GMT
On Fri, Nov 03, 2000 at 06:05:11PM -0000, trawick@locus.apache.org wrote:
> trawick     00/11/03 10:05:10
> 
>   Modified:    src/lib/apr/include apr_network_io.h
>                src/lib/apr/network_io/unix sendrecv.c
>                src/lib/apr/network_io/win32 sendrecv.c
>                src/lib/apr/test testsf.c
>   Log:
>   Make the len parm to apr_sendfile() apr_ssize_t * instead of apr_size_t *
>   for consistency with other APR network send/recv calls.

This isn't right. The apr_ssize_t implies that a negative number can be
returned. That isn't the case is it? If not, then this should be reverted.

The parameters should follow the semantic model, NOT follow something else
simply for consistency.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message