Joe Orton <joe@light.plus.com> wrote:
>On Wed, Nov 01, 2000 at 12:17:06AM +0000, Tony Finch wrote:
>...
>> There's another bit of Joe's patch that I don't understand -- it seems
>> to break calculation of the content-length. Fixing this doesn't seem
>> to fix the problem, however.
>
>The content-length calculated in ap_set_byternage is the *total*
>content-length of the multipart response, if that's what you're talking
>about... this should only be used in the success case, where the 206 is
>being returned.
Gah, I need to do more standard-reading...
>I'm not sure I see the point of that: currently, in the failure case,
>r->byterange comes out as 0, since it's never set before the error
>return. That just sets it to 2 and then sets it back to 0 again.
Because internal_byterange depends on the value of r->byterange when
deciding what to add up. When you moved the assignment to r->byterange
you changed the behaviour.
Tony.
--
en oeccget g mtcaa f.a.n.finch
v spdlkishrhtewe y dot@dotat.at
eatp o v eiti i d. fanf@covalent.net
|