httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/main http_core.c
Date Thu, 02 Nov 2000 22:15:55 GMT
On Thu, Nov 02, 2000 at 09:31:40PM -0000, sascha@locus.apache.org wrote:
>...
>   --- http_core.c	2000/11/02 20:48:48	1.194
>   +++ http_core.c	2000/11/02 21:31:37	1.195
>   @@ -2951,8 +2951,16 @@
>        int bld_content_md5 = 
>            (d->content_md5 & 1) && r->output_filters->frec->ftype
!= AP_FTYPE_CONTENT;
>    
>   -    ap_allow_methods(r, MERGE_ALLOW, "GET", "OPTIONS", NULL);
>   +    ap_allow_methods(r, MERGE_ALLOW, "GET", "OPTIONS", "POST", NULL);

Did I miss some conversation on the list about this? Why do we suddenly
allow POST methods now?

foo.html certainly doesn't take a POST method.

>...
>   @@ -2971,13 +2979,8 @@
>    		      : r->filename);
>    	return HTTP_NOT_FOUND;
>        }
>   -    if (r->method_number == M_POST) {
>   -        if ((errstatus = handle_request_body(r)) != APR_SUCCESS) {
>   -            return errstatus;
>   -        }
>   -    } else if ((errstatus = ap_discard_request_body(r)) != OK) {
>   -        return errstatus;
>   -    } else if (r->method_number != M_GET) {
>   +    
>   +    if (r->method_number != M_GET && r->method_number != M_POST) {
>            return HTTP_METHOD_NOT_ALLOWED;
>        }

Same here. foo.html better return NOT_ALLOWED if I post to it.

What is this change about?

And this kind of falls back to the behavior to change the discarding. I
don't understand what was broken, and why these few patches are attempting
to "fix" it.

Is there some discussion that occurred that you can point me at to go back
and read?

thx,
-g


-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message