httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <dr...@jetnet.co.uk>
Subject Re: apr_sockaddr_t
Date Fri, 10 Nov 2000 14:58:10 GMT
>
> Sure (+1)...
>
> Some minor suggestions...
>
> >+    apr_pool_t *cont;              /* The pool to use... */
>
>   Consider renaming field "cont" to "p" or "pool"
>

OK.  the use of cont was to fit in with other structures, but hey, we can be
different.

> >+    int addr_len;                  /* How big should the address buffer
be?
> >+                                    * 16 for v4 or 48 for v6
> >+                                    * used in inet_ntop...
> >+                                    */
>
>   Consider renaming addr_len to addr_str_len

Yes, this also makes sense.
>
> >+    char *port_str;                /* String representation of port
> >*/
>
>   Consider reserving space for the port string directly in the
>   apr_sockaddr_t:
>
>       char port_str[6];

This makes sense, but I wasn't sure what the biggest string we could have
would be?  Is 6 big enough?

david


Mime
View raw message