Return-Path: 
 <new-httpd-return-8750-apmail-new-httpd-archive=apache.org@apache.org>
Delivered-To: apmail-new-httpd-archive@apache.org
Received: (qmail 13942 invoked by uid 500); 12 Oct 2000 13:43:31 -0000
Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
list-help: <mailto:new-httpd-help@apache.org>
list-unsubscribe: <mailto:new-httpd-unsubscribe@apache.org>
list-post: <mailto:new-httpd@apache.org>
Delivered-To: mailing list new-httpd@apache.org
Received: (qmail 13886 invoked from network); 12 Oct 2000 13:43:30 -0000
X-Authentication-Warning: koj: rbb owned process doing -bs
Date: Thu, 12 Oct 2000 06:44:20 -0700 (PDT)
From: rbb@covalent.net
X-Sender: rbb@koj
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-2.0/src/main http_protocol.c
In-Reply-To: <20001011231911.S347@lyra.org>
Message-ID: <Pine.LNX.4.21.0010120643320.17582-100000@koj>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N


> > Oh, if we didn't return that much data, the http_filter really shouldn't
> > know or care about that.  It is up to ap_get_client_block to inform
> > http_filter how much data it wants next time.  The reason for this, is
> > that ap_get_client_block doesn't just use the content-length to determine
> > how much to grab, it also uses the size of the buffer passed into the
> > function.
> 
> Good call. And chunking uses the marker, and the "figure out where the end
> of the request" code uses that marker.
> 
> IMO, it would make more sense to pass this value to the filter function,
> instead of storing it off to the side in the conn_rec.
> 
> Consider: ap_get_client_block() is going to read from an *arbitrary* filter.
> Is *that* filter supposed to look at c->remaining? Or is that value only for
> the http_filter?
> 
> 
> Let's just add an apr_size_t as a param to the input filter to say "give me
> no more than <this> amount of data."  (it is legal to return less)

I have no problem adding that field, I would actually kind of rather add
that field than use the c->remaining flag, but I was hesitant to do that
immediately.  Yes, it is always legal to return less than asked for, but
never more.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------