Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Tue, 31 Oct 2000 14:39:51 -0800
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Cc: apbugs@apache.org
Subject: Re: general/6711: byterange problems in 1.3.14
Message-ID: <20001031143951.J7867@lyra.org>
Mail-Followup-To: new-httpd@apache.org, apbugs@apache.org
References: <20001031161214.1812.qmail@locus.apache.org>
 <001201c04371$270fdb90$92c0b0d0@roweclan.net>
 <20001031223040.C16227@hand.dotat.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20001031223040.C16227@hand.dotat.at>;
 from dot@dotat.at on Tue, Oct 31, 2000 at 10:30:40PM +0000

On Tue, Oct 31, 2000 at 10:30:40PM +0000, Tony Finch wrote:
> "William A. Rowe, Jr." <wrowe@rowe-clan.net> wrote:
> >
> >There was a patch to the byterange handling in http_protocol.c
> >that possibly corresponds to this issue.  I've attached the
> >1.3.12->1.3.14 diff below the report.  It smells like a bug,
> >although it could simply be a bug in Apache's .pdf handling.
> >Whichever, we may have broken clients.
> 
> The patch is broken. It introduces a new return value for
> internal_byterange but it doesn't change all the code that calls
> internal_byterange (directly or indirectly) to accommodate the change.
> e.g. default_handler calls ap_each_byterange assuming that the return
> value is boolean; ap_each_byterange is a wrapper around
> internal_byterange which does not return a boolean.

urk. my fault :-(

Tony: are you going to commit a patch, or shall I dig in?

thx,
-g

-- 
Greg Stein, http://www.lyra.org/