Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Wed, 11 Oct 2000 16:41:44 -0700
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-2.0/src/lib/apr/include apr.h.in apr.hw
Message-ID: <20001011164144.L347@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <20001011170509.4894.qmail@locus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20001011170509.4894.qmail@locus.apache.org>;
 from wrowe@locus.apache.org on Wed, Oct 11, 2000 at 05:05:09PM -0000

On Wed, Oct 11, 2000 at 05:05:09PM -0000, wrowe@locus.apache.org wrote:
> wrowe       00/10/11 10:05:07
> 
>   Modified:    src/lib/apr/include apr.h.in apr.hw
>   Log:
>     Take Greg's criticism very literally.  EXPORT (when it's really IMPORT)
>     is a true Lewis Carrollism.  This patch replaces the following:
>   
>       APR_EXPORT()        -> APR_DECLARE()         This is a public fn
>       APR_EXPORT_NONSTD() -> APR_DECLARE_NONSTD()  This is a varargs fn
>       APR_VAR_EXPORT      -> APR_DECLARE_DATA      These are public vars
>       APR_VAR_IMPORT      -> APR_DECLARE_DATA      ditto
>   
>       APR_EXPORT_SYMBOLS  -> APR_DECLARE_EXPORT    Compile the lib to export
>       APR_STATIC          -> APR_DECLARE_STATIC    Compile:linked to the .lib
>       no define                                    Compile:linked to the .dll
>   
>     The old symbols are retained in-place.  I will wait for the firestorm
>     of controversy to die before we actually use these symbols in the APR,
>     or will back out the new names under CtR

+1 !!

-- 
Greg Stein, http://www.lyra.org/