Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 58483 invoked by uid 500); 3 Oct 2000 17:34:33 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 58324 invoked from network); 3 Oct 2000 17:34:30 -0000 Message-ID: <029101c02d61$04766700$e4421b09@raleigh.ibm.com> From: "Bill Stoddard" To: References: Subject: Re: cvs commit: apache-2.0/src/ap ap_buckets.c Date: Tue, 3 Oct 2000 13:40:27 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2314.1300 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2314.1300 X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > > Modified: src/ap ap_buckets.c > > Log: > > ap_split_brigade needs to check to see if there are more buckets left in the brigade > > before proceeding with the split. > > I kind of dislike this. It is non-orthogonal to what the bucket split > functions do. I would rather see the ap_split_brigade function always > return two brigades. Either may be an empty brigade, but there will > always be two valid brigades. > > Ryan The chunk filter checks for more == NULL. I suppose we could check for AP_BRIGADE_EMPTY. Is that what you are suggesting? What would this buy us (other than overhead to create an empty brigade)? Bill