From new-httpd-return-8738-apmail-new-httpd-archive=apache.org@apache.org Thu Oct 12 05:04:51 2000 Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 42035 invoked by uid 500); 12 Oct 2000 05:04:46 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 42018 invoked from network); 12 Oct 2000 05:04:45 -0000 X-Authentication-Warning: koj: rbb owned process doing -bs Date: Wed, 11 Oct 2000 22:05:47 -0700 (PDT) From: rbb@covalent.net X-Sender: rbb@koj To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/main http_protocol.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > > if (!r->read_chunked) { /* Content-length read */ > > ap_bucket *b; > > const char *tempbuf; > > + > > + if (!r->remaining) { > > + /* We can't call http_filter() again to find out because when > > + * c->remaining is zero it returns lines of protocol data. > > + */ > > + return 0; > > + } > > This is a good change that needs to be made. I take this back. :-) look at the code about three lines down. We make the same check, but we make the check against the len_to_read variable. This allows us to fail if the buffer passed in is bad as well. That is an important check that we need, and shouldn't short circuit. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------