httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: [PATCH] clean up warnings in http_core.c
Date Mon, 30 Oct 2000 16:03:33 GMT
Cliff Woolley <cliffwoolley@yahoo.com> writes:

> --- Jeff Trawick <trawickj@bellsouth.net> wrote:
> > I also noticed that we have the same issue in http_core.c with the use
> > of apr_sendfile().  Making the len parameter to apr_sendfile()
> > apr_ssize_t* instead of apr_size_t* should resolve the issue nicely
> > and improve consistency among similar parameters in other APR
> > routines.
> 
> I was just looking into this, and at first glance it seems that doing this is going
> to cause lots of cascading pointer incompatibilities within apr_sendfile() (fixable,
> but a lot of work due to the many different definitions of apr_sendfile() for
> various platforms).  I'll do it if you're sure it's The Right Way... I just thought
> I'd double-check first.  Would it be better to go the other way and change nbytes
> (and maybe flen?) in core_output_filter() of http_core.c from apr_ssize_t to
> apr_size_t?  It would definitely be easier...

I kind of think that the right solution is apr_ssize_t due to
increased consistency through APR, even if it causes some playing
around in core_output_filter...  (It is more consistent, right?)

I don't mind playing with this if you want to punt.

Thanks a bunch...

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message