httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: [PATCH] core_input_filter with socket bucket
Date Wed, 11 Oct 2000 16:51:07 GMT
Just a quick comment on one little detail: writes:

>                                                          BTW, this would
> have been posted earlier today, but our destroy functions for buckets take
> b->data as an argument not b, so I was getting a lot of seg faults until I
> read the docs.  :-(

I think the real problem is that we're sometimes calling
e->destroy(something) in places where we need to call
ap_bucket_destroy(e).  In the code you posted, shouldn't we use
ap_bucket_destroy(e) instead?  

I just looked through a copy of http_protocol.c which matches CVS
pretty closely and every instance of e->destroy() (or in one case
b->destroy()) should be ap_bucket_destroy() (88% sure :) ).

Jeff Trawick | | PGP public key at web site:
          Born in Roswell... married an alien...

View raw message