httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] dechunking, body filtering (fwd)
Date Sat, 14 Oct 2000 15:55:44 GMT

> The problem here is that we are completely wrong with the http_filter.  I
> will take complete responsability for that, because I wrote it
> initially.  The clean solution, is to move the http_filter from a
> connection based filter to a request based filter.  This allows
> http_filter to learn the content-length from the actual request.  It also
> allows ap_get_client_block to just call ap_get_brigade until it gets an
> EOS.
> 
> The chunking filter would go on top of http_filter just to keep
> http_filter simpler.  It could be a part of http_filter, but I would
> prefer to separate the code a bit.  I will not be writing the de-chunking
> filter right now.  I want to re-org http_filter first.  Expect a commit
> later today that makes this change.  This should remove a LOT of the
> contentious points from the discussion, because there is no need to tell
> the http_filter anything, it will be able to just discover it for itself.

ARGH!  Now I remember why I didn't do this originally.  It would put the
brigade inside a filter that is destroyed when the request_rec goes
away.  Thats not going to work after all.  :-(

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message