httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] dechunking, body filtering
Date Sat, 14 Oct 2000 07:21:06 GMT

I have reviewed the patch in some detail and some parts of it are very
good.  Others I just can't agree with.  Some sketchy comments below.  I'll
make more comments tomorrow morning.

> Data structure changes
>   http_filter's ctx:
>     Add remaining field.  ap_setup_client_block() and dechunk_filter() know how to
>     find this ctx and set this field.

You can't do this.  You can't even garauntee that http_filter will be in
the server.  I have every intention of writing an input filter that takes
ftp requests and converts them to http.  When I do that, there will be no
http_filter in the request, and this will break.  No filter can EVER
depend on another filter being in the stack.

>   r
>     Add "void *filtered_input" field; ap_get_client_block() holds onto 
>     leftover body in this field.  Ugly that we clutter the r...  Ugly that
>     I made it "void *" instead of "ap_bucket_brigade *" (avoids an additional
>     #include in "httpd.h" for (probably) no good reason).

This was discussed yesterday and people really disliked it.  If filters
are told the maximum amount of data they can return, this is unnecessary.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message