httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main http_protocol.c
Date Thu, 12 Oct 2000 13:40:02 GMT
On Wed, 11 Oct 2000, Greg Stein wrote:

> On Wed, Oct 11, 2000 at 10:08:29PM -0700, rbb@covalent.net wrote:

> > Another thing I should clear up here.  ap_get_client_block doesn't need to
> > store it's data in a private bucket_brigade.  It should ALWAYS return
> > whatever data it can to the caller, because that is the way modules expect
> > it to work.
> 
> But what happens if the brigade contains more than the caller asked for?
> ap_get_client_block() must store that somewhere.
> 
> Where does it store the unread input?

Currently, it falls on the ground, which is wrong, you are correct.  But,
this can't go at the connection level, because we are really far above the
connection level when we are in ap_get_client_block.  This needs to be in
the request_rec.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message