httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main http_core.c
Date Mon, 09 Oct 2000 15:35:44 GMT
On 9 Oct 2000, Jeff Trawick wrote:

> rbb@locus.apache.org writes:
> 
> > rbb         00/10/07 11:10:07
> > 
> >   Modified:    src/include httpd.h
> >                src/main http_core.c
> >   Log:
> >   The core filter should not be using its own brigade inside its own ctx
> >   structure.  This changes the core_output_filter to use a brigade inside
> >   the conn_rec.  Think of this as analagous to the BUFF in the conn_rec.
> >   The idea is that if we have pipelined requests, and it isn't worth it to
> >   send the last bit of data from the first request, we want to save that
> >   extra bit of data to the conn_rec, so that the next request sends it
> >   automatically.
> 
> But we use the same instance of CORE across the entire connection, so
> its context data has the right lifetime...  Right?
> 
> Using the context data when possible seems to be more friendly than
> adding more stuff to the conn_rec.

This isn't really adding anything to the conn_rec, it is replacing the
BUFF with a brigade.  I guess the core's ctx does have the correct
lifetime now that we are putting it in the conn_rec.  I'm not opposed to
backing this out.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message