httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main http_protocol.c
Date Sun, 08 Oct 2000 19:01:49 GMT

> >            if ((toss = ap_strchr_c(temp, ASCII_LF)) != NULL) {
> >                length = toss - temp + 1;
> >   -            e->split(e, length + (temp[length] == 0));
> >   +            e->split(e, length + (temp[length] == '\0' ? 1 : 0));
> 
> Bluch! == returns 0 or 1 already. The '\0' instead of 0 I agree with.

According to OtherBill, == can return -1 on some platforms.  I would much
prefer to just use ==, because it is cleaner.  Can we leave it as is for
today, because I am about to commit my fix for the char-at-a-time problem,
and later today I am rolling an alpha.  Can we discuss/change this
tomorrow?  I just want to get the alpha out today if at all possible.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message