httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-2.0/src/lib/apr/file_io/win32 open.c
Date Fri, 06 Oct 2000 23:07:36 GMT

> >   apr_open() always allocates storage for the apr_file_t now. The caller is no
> >   longer responsible for initializing their apr_file_t* to NULL.
> Does anybody feel it is important to clear out all the NULL initializations
> throughout Apache? I have them handy, but am tempted to just leave them as
> is. Especially for that odd case where the NULL status is used as an error
> cleanup situation ("I didn't open the file yet").
> Thoughts?

I am always much more comfortable with initializing variables.  If we are
going to remove these, can it wait until after Sunday?  I would prefer we
didn't break things this close to an alpha.  At least not any more than
they already are.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message