httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: FW: cvs commit: apache-2.0/src/main http_core.c http_protocol.c http_request.c
Date Tue, 03 Oct 2000 20:54:03 GMT
On Tue, 3 Oct 2000, Greg Ames wrote:

> 
> 
> rbb@covalent.net wrote:
> 
> >   Modified:    src      CHANGES
> >                src/main http_core.c http_protocol.c http_request.c
> >   Log:
> >   Combine the calls to add the core_filter to one place.  Basically, it is
> >   safe to add the core_filter during the post_read_request, and it means
> >   that we only have to add the filter once in the code.  This should make
> >   it easier to add an SSL module in the future.
> 
> Unfortunately, post_read_request isn't soon enough :-(.  There are a number of
> HTTP protocol errors  detected by ap_read_request prior to this hook, and
> we're back to getting no error response body.  Here are a couple of failed
> test cases:
> 
> [greg@ojibwa src]$ nc 127.0.0.1 80
> GET / HTTP/1.0
> no_colon
> 
> HTTP/1.1 400 Bad Request
> Date: Tue, 03 Oct 2000 17:14:31 GMT
> Server: Apache/2.0a7 (Unix)
> Connection: close
> Content-Type: text/html; charset=iso-8859-1
> 
> [greg@ojibwa src]$ nc 127.0.0.1 80
> HEAD /                            <-- Note that HEAD is illegal for HTTP 0.9
> [greg@ojibwa src]$
> 
> I'll back out this change, then post a suggestion for dealing with SSL.

Backing out the change won't solve this.  Take a look at what I really
did.  I moved a call to ap_add_filter down two or three lines.  Backing
out the change logically should affect this at all.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message