httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-2.0/src/main http_protocol.c
Date Sun, 29 Oct 2000 16:07:59 GMT
rbb@covalent.net wrote:
> 
> > >            if ((toss = ap_strchr_c(temp, ASCII_LF)) != NULL) {
> > >                length = toss - temp + 1;
> > >   -            e->split(e, length + (temp[length] == 0));
> > >   +            e->split(e, length + (temp[length] == '\0' ? 1 : 0));
> >
> > Bluch! == returns 0 or 1 already. The '\0' instead of 0 I agree with.
> 
> According to OtherBill, == can return -1 on some platforms. 

OtherBill is wrong! K&R Ed. 2, A7.9 says relational operators yield 0 or
1, and A7.10 says equality operators are analogous to relational
operators.

> I would much
> prefer to just use ==, because it is cleaner.  Can we leave it as is for
> today, because I am about to commit my fix for the char-at-a-time problem,
> and later today I am rolling an alpha.  Can we discuss/change this
> tomorrow?  I just want to get the alpha out today if at all possible.

So here we are discussing it three weeks later, coz I'm finally catching
up with mail :-)

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit."

Robert Woodruff

Mime
View raw message