httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <>
Subject Re: [PATCH] dechunking, body filtering
Date Mon, 16 Oct 2000 20:54:17 GMT wrote:

> > +static apr_status_t brigade_bgets(ap_bucket_brigade *bb,
> > +                                  int remove_buckets,
> > +                                  char *line,
> > +                                  apr_ssize_t max_line_size)
> <brigade_bgets snipped for brevity>
> Why isn't this just getline?  This does a bit less than getline, but
> getline is already there, and it is one less place for things to go wrong.

Hmmm, reusing code that gets pounded is a good idea.  But it won't work
as-is because of minor differences in parms, function, and environment
(filter vs. non-filter).

I'm doing minor tweaks to getline() at the moment for other reasons. 
Once I get done with that, I'll see if we can factor out the common
denominator & turn getline() into a wrapper.


View raw message