httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Finch <...@dotat.at>
Subject Re: general/6711: byterange problems in 1.3.14
Date Wed, 01 Nov 2000 00:17:06 GMT
Tony Finch <dot@dotat.at> wrote:
> 
> You are right -- I missed that. I'm looking at parse_byterange now
> because I think that may be the culprit.

Or maybe not. I think I am seeing the problem now but although IE
sometimes pauses for seconds when reloading the PDF file, the
transaction looks no different from my end of the connection *except*
that it seems to be associated with new connections -- keep-alive
connections are fast.

(Bah, why can't Windows close a TCP connection properly?)

There's another bit of Joe's patch that I don't understand -- it seems
to break calculation of the content-length. Fixing this doesn't seem
to fix the problem, however.

Tony.
-- 
en oeccget g mtcaa    f.a.n.finch
v spdlkishrhtewe y    dot@dotat.at
eatp o v eiti i d.    fanf@covalent.net


Index: http_protocol.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/main/http_protocol.c,v
retrieving revision 1.291
diff -u -r1.291 http_protocol.c
--- http_protocol.c	2000/10/10 03:29:08	1.291
+++ http_protocol.c	2000/11/01 00:15:02
@@ -237,6 +269,7 @@
         long tlength = 0;
 	int ret;
 	
+        r->byterange = 2;
         r->boundary = ap_psprintf(r->pool, "%lx%lx",
 				r->request_time, (long) getpid());
         do {
@@ -245,11 +278,12 @@
 	} while (ret == 1);
 	/* If an error occured processing one of the range specs, we
 	 * must fail */
-	if (ret < 0)
+	if (ret < 0) {
+	    r->byterange = 0;
 	    return 0;
+	}
         ap_table_setn(r->headers_out, "Content-Length",
 	    ap_psprintf(r->pool, "%ld", tlength));
-        r->byterange = 2;
     }
 
     r->status = PARTIAL_CONTENT;

Mime
View raw message