httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: general/6711: byterange problems in 1.3.14
Date Tue, 31 Oct 2000 22:39:51 GMT
On Tue, Oct 31, 2000 at 10:30:40PM +0000, Tony Finch wrote:
> "William A. Rowe, Jr." <wrowe@rowe-clan.net> wrote:
> >
> >There was a patch to the byterange handling in http_protocol.c
> >that possibly corresponds to this issue.  I've attached the
> >1.3.12->1.3.14 diff below the report.  It smells like a bug,
> >although it could simply be a bug in Apache's .pdf handling.
> >Whichever, we may have broken clients.
> 
> The patch is broken. It introduces a new return value for
> internal_byterange but it doesn't change all the code that calls
> internal_byterange (directly or indirectly) to accommodate the change.
> e.g. default_handler calls ap_each_byterange assuming that the return
> value is boolean; ap_each_byterange is a wrapper around
> internal_byterange which does not return a boolean.

urk. my fault :-(

Tony: are you going to commit a patch, or shall I dig in?

thx,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message