httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject [PATCH](?) bucket type init declaration
Date Sat, 21 Oct 2000 20:09:18 GMT

Can somebody tell me why this patch is incorrect?  (Greg? Ryan?)  It just seems
to me that these either needed to be static (which doesn't apply here) or
AP_DECLARE'd.  Is there a reason for a function to be neither, or was this an
accident?

Index: ap/ap_buckets.c
===================================================================
RCS file: /home/cvspublic/apache-2.0/src/ap/ap_buckets.c,v
retrieving revision 1.27
diff -u -r1.27 ap_buckets.c
--- ap/ap_buckets.c	2000/10/16 14:08:21	1.27
+++ ap/ap_buckets.c	2000/10/21 19:50:37
@@ -83,6 +83,7 @@
      */
     return APR_SUCCESS;
 }
+
 AP_DECLARE(apr_status_t) ap_brigade_destroy(ap_bucket_brigade *b)
 {
     apr_kill_cleanup(b->p, b, ap_brigade_cleanup);
@@ -203,7 +204,7 @@
     return res;
 }
 
-void ap_init_bucket_types(apr_pool_t *p)
+AP_DECLARE(void) ap_init_bucket_types(apr_pool_t *p)
 {
     bucket_types = apr_make_array(p, 8, sizeof(ap_bucket_type));
 
@@ -217,7 +218,7 @@
     ap_insert_bucket_type(&ap_socket_type);
 }
 
-int ap_insert_bucket_type(const ap_bucket_type *type)
+AP_DECLARE(int) ap_insert_bucket_type(const ap_bucket_type *type)
 {
     const ap_bucket_type **newone;
 
Index: include/ap_buckets.h
===================================================================
RCS file: /home/cvspublic/apache-2.0/src/include/ap_buckets.h,v
retrieving revision 1.45
diff -u -r1.45 ap_buckets.h
--- include/ap_buckets.h	2000/10/17 21:53:42	1.45
+++ include/ap_buckets.h	2000/10/21 19:50:41
@@ -488,7 +488,7 @@
  * @param p The pool to allocate the array out of.
  * @deffunc void ap_init_bucket_types(apr_pool_t *p)
  */
-void ap_init_bucket_types(apr_pool_t *p);
+AP_DECLARE(void) ap_init_bucket_types(apr_pool_t *p);
 
 /**
  * free the resources used by a bucket. If multiple buckets refer to
@@ -537,7 +537,7 @@
 AP_DECLARE_NONSTD(void) ap_bucket_destroy_notimpl(void *data);
 /* There is no ap_bucket_read_notimpl, because it is a required function
  */
-int ap_insert_bucket_type(const ap_bucket_type *type);
+AP_DECLARE(int) ap_insert_bucket_type(const ap_bucket_type *type);
 
 /* All of the bucket types implemented by the core */
 extern const ap_bucket_type ap_flush_type;


__________________________________________________
Do You Yahoo!?
Yahoo! Messenger - Talk while you surf!  It's FREE.
http://im.yahoo.com/

Mime
View raw message