httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr_time.h
Date Tue, 17 Oct 2000 06:48:57 GMT
I was about to add the extern like that, but I wasn't sure whether that was
the proper form for the Windows platform.

Also, the doc for APR_DECLARE_DATA states the form is:

  type APR_DECLARE_DATA apr_variable;

However, the APR_DECLARE_DATA below doesn't match that. What is the
appropriate form, and can we sync the usage and doc? I'm happy to change it
if we can get some clarification.

It might also be nice if the doc shows the sometimes-there extern in there.

btw, it looks like this stuff here in apr_time.h is the only use of
APR_DECLARE_DATA that we need to deal with.

thx,
-g

On Tue, Oct 17, 2000 at 03:54:45AM -0000, wrowe@locus.apache.org wrote:
> wrowe       00/10/16 20:54:44
> 
>   Modified:    src/lib/apr/include apr_time.h
>   Log:
>     Ugh... had different meaning between apr and ap.  Not good, all fixed.
>   
>   Submitted by:	Karl Fogel <kfogel@collab.net>
>   Reviewed by:	Greg Stein
>   
>   Revision  Changes    Path
>   1.28      +2 -2      apache-2.0/src/lib/apr/include/apr_time.h
>   
>   Index: apr_time.h
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_time.h,v
>   retrieving revision 1.27
>   retrieving revision 1.28
>   diff -u -r1.27 -r1.28
>   --- apr_time.h	2000/10/16 06:18:19	1.27
>   +++ apr_time.h	2000/10/17 03:54:43	1.28
>   @@ -66,8 +66,8 @@
>     * @package APR Time library
>     */
>    
>   -APR_DECLARE_DATA const char apr_month_snames[12][4];
>   -APR_DECLARE_DATA const char apr_day_snames[7][4];
>   +extern APR_DECLARE_DATA const char apr_month_snames[12][4];
>   +extern APR_DECLARE_DATA const char apr_day_snames[7][4];
>    
>    /* number of microseconds since 00:00:00 january 1, 1970 UTC */
>    typedef apr_int64_t apr_time_t;
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message