httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/main http_protocol.c
Date Thu, 12 Oct 2000 05:51:43 GMT
On Wed, Oct 11, 2000 at 10:08:29PM -0700, rbb@covalent.net wrote:
> 
> > > +    if (!r->connection->input_data) {
> > > +        /* XXX used only by ap_get_client_block(), lifetime is request;
> > > +         * move from c to r and fix the pool
> > > +         */
> > > +        r->connection->input_data = ap_brigade_create(r->connection->pool);
> > > +    }
> > 
> > I stopped using r->connection->input_data, because it isn't this filter's
> > to use.  In fact, this can actually go away now.  The whole point of this
> > brigade, was to give the core filter a place to store information.  It is
> > incorrect for any filter to have access to a brigade in the conn_rec.
> 
> Another thing I should clear up here.  ap_get_client_block doesn't need to
> store it's data in a private bucket_brigade.  It should ALWAYS return
> whatever data it can to the caller, because that is the way modules expect
> it to work.

But what happens if the brigade contains more than the caller asked for?
ap_get_client_block() must store that somewhere.

Where does it store the unread input?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message