httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/ap ap_buckets.c
Date Tue, 03 Oct 2000 17:40:27 GMT
> >   Modified:    src/ap   ap_buckets.c
> >   Log:
> >   ap_split_brigade needs to check to see if there are more buckets left in
the brigade
> >   before proceeding with the split.
>
> I kind of dislike this.  It is non-orthogonal to what the bucket split
> functions do.  I would rather see the ap_split_brigade function always
> return two brigades.  Either may be an empty brigade, but there will
> always be two valid brigades.
>
> Ryan

The chunk filter checks for more == NULL. I suppose we could check for
AP_BRIGADE_EMPTY. Is that what you are suggesting? What would this buy us (other
than overhead to create an empty brigade)?

Bill


Mime
View raw message