httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject RE: cvs commit: apache-2.0/src/modules/dav/main liveprop.c mod_dav.c mod_dav.h providers.c util.c util_lock.c
Date Thu, 12 Oct 2000 01:25:35 GMT
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Wednesday, October 11, 2000 6:53 PM
> 
> On Wed, Oct 11, 2000 at 05:23:58PM -0000, 
> wrowe@locus.apache.org wrote:
> > wrowe       00/10/11 10:23:58
> > 
> >   --- mod_dav_fs.c	2000/10/07 01:29:38	1.8
> >   +++ mod_dav_fs.c	2000/10/11 17:23:52	1.9
> >   @@ -64,7 +64,7 @@
> >    
> >    } dav_fs_server_conf;
> >    
> >   -extern module MODULE_VAR_EXPORT dav_fs_module;
> >   +extern module MODULE_DECLARE_DATA dav_fs_module;
> >    
> >    const char *dav_get_lockdb_path(const request_rec *r)
> >    {
> >   @@ -130,7 +130,7 @@
> >        dav_fs_register(NULL /* ### pconf */);
> >    }
> >    
> >   -module MODULE_VAR_EXPORT dav_fs_module =
> >   +module MODULE_DECLARE_DATA dav_fs_module =
> 
> Why are these MODULE_* rather than DAV_* ??

ap_mod_fs.dll is it's own dll.  We don't need to waste time building
DAV_FS_ tags when it has only one export, which is never even parsed
by another module from a header declaration.
 
> Oh. I think I start to get it. All modules must export their "module" data.
> The MODULE_DECLARE_DATA gives them a way to do that. Hmmm.... but that
> doesn't mean they should have the other DECLARE macros. It may be nice to
> instead use something like AP_EXPORT_MODULE_SYMBOL (or whatever). Something
> that says "this is for exporting your <module> item."

I'll consider that... quite honestly a little tired of thinking about 
it today :-/  You are right, though, that MODULE_ is the only family
that really -ment- EXPORT, all the time.  The others ment export sometimes,
import at others, and that's why I bought DECLARE over EXPORT.

Mime
View raw message