httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: apache-2.0/src/ap ap_buckets_mmap.c
Date Mon, 11 Sep 2000 18:54:13 GMT
Doug MacEachern <dougm@covalent.net> writes:

> On Mon, 11 Sep 2000, Greg Stein wrote:
> 
> > I don't understand this one. How can bucket.data end up as NULL? AFAIK, that
> > just shouldn't happen.
> 
> as i said in the commit message, it happens if a filter doesn't send any
> data downstream.  i'm just starting to play with filtering, i had a
> mod_test_filter.c with a:
> apr_status_t filter_handler(ap_filter_t *f, ap_bucket_brigade *bb)
> 
> that did not call ap_pass_brigade(), or do anything for that matter.
> yeah, that shouldn't happen, but it can and dumb filters shouldn't be able
> to make apache segv.

We can't keep dumb module code from making apache segv without
introducing a lot of overhead (to run module code in a sandbox).

If it were my module, I'd rather it segv.  I'd find/fix the bug much
quicker that way.

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message