httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_include.c
Date Sun, 17 Sep 2000 01:34:24 GMT
> > Here is your original loop:
> > 
> >         if ((tagbuck = find_string(dptr,STARTING_SEQUENCE, AP_BRIGADE_LAST(bb)))
!= NULL) {
> >             dptr2 = tagbuck;
> >             dptr = tagbuck;
> >             while (dptr2 && 
> >                   (endsec = find_string(dptr2, ENDING_SEQUENCE, AP_BRIGADE_LAST(bb)))
== NULL) {
> >                 dptr2 = AP_BUCKET_NEXT(dptr2);
> >             }
> >             if (endsec == NULL) {
> >                 /** No ending tag, needs to become an error bucket */
> >             }
> > 
> > The conditions for your while loop make no sense.  dptr2 will never
> > become NULL and there is no guarantee that we'll find the ending
> > sequence in this brigade.
> 
> No, that's wrong.  dptr2 is NULL if the starting sequence is not found.

Okay, I'm a moron.  Hit me with a wet noodle.  I wrote this, sent it, then
went to wash dishes, and finally saw what you were saying.  I'll go sit in
the corner until I learn to pay more attention.  Sorry.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message