httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_include.c
Date Sat, 16 Sep 2000 02:07:59 GMT

> > >   Get rid of an endless loop (waiting for dptr2 to become NULL instead of
> > >   AP_BRIGADE_SENTINEL()).
> > 
> > This change is also incorrect.  If the find_string does not find the
> > starting sequence, then it will return NULL.  With this change, we will
> > search for an ending sequence even if we don't have a starting
> > sequence.
> 
> This check prevents a hard loop which was quite easy to get into.
> Simply backing it out would not be cool.  I'll look into that loop
> again with your comments in mind and look for the better fix.

Add the check back that you removed.  Leave the check that you
added.  That's all that is needed.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------



Mime
View raw message