httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: cvs commit: apache-2.0/src/ap ap_buckets_mmap.c
Date Mon, 11 Sep 2000 18:00:26 GMT
On Mon, 11 Sep 2000, Greg Stein wrote:

> I don't understand this one. How can bucket.data end up as NULL? AFAIK, that
> just shouldn't happen.

as i said in the commit message, it happens if a filter doesn't send any
data downstream.  i'm just starting to play with filtering, i had a
mod_test_filter.c with a:
apr_status_t filter_handler(ap_filter_t *f, ap_bucket_brigade *bb)

that did not call ap_pass_brigade(), or do anything for that matter.
yeah, that shouldn't happen, but it can and dumb filters shouldn't be able
to make apache segv.

> The patch below seems to only fix the symptom, not the original cause.

maybe, but that routine already does a similar check:
    m = ap_bucket_destroy_shared(data);
    if (m == NULL) {
	return;
    }

i don't see a problem with another sanity check there.  if there's a
better fix i'd be happy to see it.


Mime
View raw message