httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <>
Subject Re: [PATCH] filtering and canned error responses
Date Wed, 13 Sep 2000 21:38:49 GMT
Greg Ames wrote:
> OK - why don't we get rolling on the fallback piece since we need it no
> matter what?


> I'll take a look at Jeff's patch this afternoon and see if it seems
> appropriate for the worst case scenarios.

One suggestion - let's change this code so that the retrieving of the
canned error html strings is isolated from the delivery mechanism.  In
other words, move the big switch(status)/case HTTP_blah
chunk of code out of ap_send_error_response and into a static helper
function which take a status code as input and returns the canned error
string.  Then no matter how the delivery mechanism evolves, it will be
pretty easy to tweak ap_send_error_response.

I'll do this unless somebody screams or beats me to it.


View raw message