httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/ap ap_buckets_mmap.c
Date Mon, 11 Sep 2000 09:38:22 GMT
I don't understand this one. How can bucket.data end up as NULL? AFAIK, that
just shouldn't happen.

The patch below seems to only fix the symptom, not the original cause.

Cheers,
-g

On Mon, Sep 11, 2000 at 04:33:31AM -0000, dougm@locus.apache.org wrote:
> dougm       00/09/10 21:33:31
> 
>   Modified:    src/ap   ap_buckets_mmap.c
>   Log:
>   if a filter fumbles and does not send anything downstream, data == NULL == SEGV
>   
>   Revision  Changes    Path
>   1.8       +4 -0      apache-2.0/src/ap/ap_buckets_mmap.c
>   
>   Index: ap_buckets_mmap.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/ap/ap_buckets_mmap.c,v
>   retrieving revision 1.7
>   retrieving revision 1.8
>   diff -u -r1.7 -r1.8
>   --- ap_buckets_mmap.c	2000/08/19 16:54:45	1.7
>   +++ ap_buckets_mmap.c	2000/09/11 04:33:31	1.8
>   @@ -77,6 +77,10 @@
>    {
>        ap_bucket_mmap *m;
>    
>   +    if (data == NULL) {
>   +        return;
>   +    }
>   +
>        m = ap_bucket_destroy_shared(data);
>        if (m == NULL) {
>    	return;
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message