Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Wed, 16 Aug 2000 12:10:15 -0700
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: [PATCH] ap_add_filter
Message-ID: <20000816121015.L17689@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <Pine.LNX.4.21.0008161121320.29636-100000@koj.rkbloom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <Pine.LNX.4.21.0008161121320.29636-100000@koj.rkbloom.net>;
 from rbb@covalent.net on Wed, Aug 16, 2000 at 11:48:30AM -0700

This is incorrect, per my other email.  -1

On Wed, Aug 16, 2000 at 11:48:30AM -0700, rbb@covalent.net wrote:
> 
> This is the promised patch for ap_add_filter.  This makes ap_add_filter
> use a LIFO stack instead of a FIFO queue.  I will commit this patch later
> today unless somebody speaks up against it.
> 
> Ryan
> 
> Index: util_filter.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/main/util_filter.c,v
> retrieving revision 1.6
> diff -u -d -b -w -u -r1.6 util_filter.c
> --- util_filter.c	2000/08/14 17:50:02	1.6
> +++ util_filter.c	2000/08/16 18:15:45
> @@ -90,8 +90,8 @@
>  ** filter; 2) that filter has a higher filter type (class); 3) that filter
>  ** corresponds to a different request.
>  */
> -#define INSERT_BEFORE(f, before_this) ((before_this) == NULL \
> -                                       || (before_this)->ftype > (f)->ftype)
> +#define INSERT_AFTER(f, after_this) ((after_this) == NULL \
> +                                       || (after_this)->ftype <= (f)->ftype)
>  
>  
>  static apr_status_t filter_cleanup(void *ctx)
> @@ -129,13 +129,13 @@
>              f->ftype = frec->ftype;
>              f->r = r;
>  
> -            if (INSERT_BEFORE(f, r->filters)) {
> +            if (INSERT_AFTER(f, r->filters)) {
>                  f->next = r->filters;
>                  r->filters = f;
>              }
>              else {
>                  ap_filter_t *fscan = r->filters;
> -                while (!INSERT_BEFORE(f, fscan->next))
> +                while (!INSERT_AFTER(f, fscan->next))
>                      fscan = fscan->next;
>                  f->next = fscan->next;
>                  fscan->next = f;
> 
> _______________________________________________________________________________
> Ryan Bloom                        	rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> -------------------------------------------------------------------------------
> 

-- 
Greg Stein, http://www.lyra.org/