Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 18742 invoked by uid 500); 15 Aug 2000 02:24:40 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 18729 invoked from network); 15 Aug 2000 02:24:39 -0000 Message-ID: <002b01c0065f$db64a5c0$65f1a218@apache> From: "Bill Stoddard" To: References: Subject: Re: ap_brigade_destroy Date: Mon, 14 Aug 2000 22:23:50 -0400 Organization: Apache Software Foundation MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6700 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N I was recalling code from long ago... I was suprised that ap_register_cleanup, et. al now supported clean-ups that return apr_status_t. I will not make this change. Bill > > I haven't even thought about actually reviewing this yet, but the current > API for cleanups is: > > apr_status_t func_name(void *data); > > From your comments it sounds like we have a function that looks like that, > and you want to change it to void *func_name(void *data) so that it is a > true cleanup. What am I missing? > > Ryan > > On Mon, 14 Aug 2000, Bill Stoddard wrote: > > > > > ap_brigade_destroy(void *data) should be returning a void * rather than apr_status_t. This > > will also save a cast to void * on the function when calling ap_register_cleanup. > > > > I will change the bucket brigades cleanups to return void * if I hear no objections. > > > > Bill > > > > > > > _______________________________________________________________________________ > Ryan Bloom rbb@apache.org > 406 29th St. > San Francisco, CA 94131 > ------------------------------------------------------------------------------- >