httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: [PATCH] APRize nagle
Date Mon, 21 Aug 2000 15:03:28 GMT
"Brian Havard" <> writes:

> The current ap_sock_disable_nagle() requires an OS handle. This patch makes 
> it take an apr_socket_t * instead. Note that I had to stick my fingers into 
> MPMs & APR code I can't test which is why I'm posting the patch before 
> commiting it. Is this ok by everyone or do we need to keep the FD_SETSIZE test
> in there? I removed them because this removes the last use of the os socket in
> that part of the code.

We need the FD_SETSIZE check *somewhere* (APR fails on certain
operations otherwise).  I'd leave that code as-is until/unless
somebody changes where the test is done or removes the need for it.

Jeff Trawick | | PGP public key at web site:
          Born in Roswell... married an alien...

View raw message