httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-2.0/src/main http_core.c http_protocol.c util_filter.c
Date Tue, 29 Aug 2000 22:24:40 GMT

Before people start yelling that this patch was vetoed, I know that.  I am
committing anyway, because I have asked for two weeks for a technical
reason for the veto, and I haven't seen one yet.  I got sick of waiting,
so I decided to just commit.  This may be an unpopular decision, but I am
hoping it gets things moving again, because we keep stagnating.

If I pissed people off with this commit, sorry.  I would ask that this
commit not be backed-out until there is a valid technical reason for the
veto, because I would like to move forward, and I couldn't go anywhere
with the broken code that was there.


On 29 Aug 2000 wrote:

> rbb         00/08/29 15:16:46
>   Modified:    src/include util_filter.h
>                src/main http_core.c http_protocol.c util_filter.c
>   Log:
>   Modify the way filters are added to the server.  Instead of using a FIFO,
>   we use a modified LIFO.  It is modified, because if we add a filter while
>   in the middle of another filter, the added filter gets put in after the
>   current filter.  This requires that the server is smart about which filters
>   are added when.  This should be handled by the HTTP protocol, but we will
>   want to keep and eye on things for a little while.
>   This change is necessary, because currently when we add a filter it goes
>   after the last filter of the same type.  This is broken whenever we want
>   to add a filter that has a dependancy.  Think about the core and chunking
>   filters.  They are of the same type, and core is always added first.  When
>   we go to insert chunking, it gets added, but it is never called.

View raw message