httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] ap_add_filter
Date Sun, 27 Aug 2000 14:04:07 GMT

> OK, the filter chain management stuff doesn't look anything like I
> expected it to. I see something that looks kind of funky to me, with
> the module adding a hook so that it can add itself to the filter
> chain, and also registering itself with the core seperately.
> Why two seperate calls?

The module registers a filter so that it gets a global name that can be
used by anybody to actually insert the filter.

The insert filter hook is supposed to be used to add the filter to the
chain, but it is bogus.  I have outlined why it is bogus in previous
e-mails, so I'm not going to go into it here.

> I'm still feeling my way through this stuff, but I probably would have
> had each module return an ap_filter_t pointer in its filtering hook
> instead, and let the core engine actually add the filter to the filter
> chain. No coincedence that this "goes with" my filter chain management
> proposal :)

Which filtering hook would you have had return the ap_filter_t
pointer?  Insert_filter, the actual filter?  I would need to actually see
what you had envisioned before I could comment on it.

Since this is going to take you longer than you expected, can I commit my
patch to the tree so that we can move forward?  We are stagnating again.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message