httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] ap_add_filter
Date Sun, 20 Aug 2000 20:47:17 GMT
On Sun, 20 Aug 2000, Rodent of Unusual Size wrote:
> wrote:
> > On Fri, 18 Aug 2000, Rodent of Unusual Size wrote:
> > It would either be up to the foobar module to insert it's filter,
> > or the ap_add_filter function returns an error.  Basically, foobar
> > has to register the filter with the server.  If it isn't registered,
> > then ap_add_filter errors out.
> That's a bit of a handwave.  If the foobar filter is part of
> mod_foobar, and mod_foobar isn't part of the server's configuration,
> and a PHP script says "apache_add_output_filter('foobar');" then
> what are you expecting to happen?  The PHP function will return
> an error status?

First of all, I expect that no PHP script will say
apache_add_output_filter.  I expect it is more likely that PHP will look
at output and say add_filter(foobar).  I also expect the PHP module to log
an error and do it's best to serve a page.  The best example I can give,
would be a PHP script that include SSI's, but mod_include isn't
installed.  PHP logs an error, and sends the SSI tags to the
browser.  That's about the best we can hope for.  Hopefully, when the
admin sees the logs, they will fix the problem.

> This idea of modules mucking with the downstream filter chain
> keeps coming up, and coming up, and..  SOMEbody must have some
> examples in mind.  I'd like to hear 'em, becauss so far it sounds
> like a major hassle for little or no gain..

Well, there is the example that started the whole problem.  The chunking
filter.  This is an example that has shown the current method to not
work, and it is already in the source code.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message