httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] ap_add_filter
Date Fri, 18 Aug 2000 14:14:02 GMT

> OK, a thought that fell out while writing up my design proposal for
> 3.0.
> 
> I think think there will be scenarios where filters need to add
> new filters both before and after themselves. To me, it seems kind of
> scary to let every single filter operate directly on the "main"
> filter chain as well.

Could you please give an example of such a filter?

 <snipped for brevity>
> 
> A -> B -> Q -> C -> D -> core
> 
> when Q decides it wants its buckets to run through a couple of extra
> filters:
> 
> A -> B -> Q.interface    Q.impl           C -> D -> core
>            V             ^     V         ^
>        ___/              |     |         |
>       /                  |     |         |
>      1 -> 2 -> 3 -> 4 -> 5     6 -> 7 -> 8
> 
> 
> With this setup, Q doesn't touch the main filter chain at all to add
> its filters. Thoughts? It took way too many words to describe this,
> but it doesn't feel like a complicated concept to me.

This feels very complicated to me.  It also looks very hard to implement
in a way that is generic enough for any module to use.  I have no problem
letting modules munge the main filter stack themselves.  This just really
seems like overkill, and I can't see what it buys us.

Ryan


Mime
View raw message